cover cache-reuse + first-change paths; fix pin color under select tool - #78
Merged
Conversation
Zeljko-Predjeskovic
commented
Jul 22, 2026
Zeljko-Predjeskovic
commented
Collaborator
- RenderCacheColorTests: add SetAttributeChangeToken unit tests (unchanged token reuses brush; first/subsequent change invalidates); drop redundant ScreenWidth/Height assignments.
- ColorTool: color a selected pin's shape by element identity, not the active tool, so recoloring works under the Move/Selection tool. Adds PinColorSelectionTests.
Zeljko-Predjeskovic
force-pushed
the
fix/pin_select_color
branch
from
July 22, 2026 07:30
19185e6 to
3839151
Compare
gentledepp
requested changes
Jul 22, 2026
| foreach (var selectedElement in _canvas.SelectedElements) | ||
| { | ||
| if (t.Canvas.ActiveTool is ISupportTextColor) | ||
| if (IsPin(selectedElement)) |
Owner
There was a problem hiding this comment.
I do not like, that the ColorTool now starts to learn about every other shape in our editor.
It should not have the concept of a "Pin" - it should only work with interfaces. (Open-Closed-Principle)
When I add a nother shape, I do not want to have to edit the color tool too
- RenderCacheColorTests: add SetAttributeChangeToken unit tests (unchanged token reuses brush; first/subsequent change invalidates); drop redundant ScreenWidth/Height assignments. - ColorTool: color a selected pin's shape by element identity, not the active tool, so recoloring works under the Move/Selection tool. Adds PinColorSelectionTests.
Zeljko-Predjeskovic
force-pushed
the
fix/pin_select_color
branch
from
July 22, 2026 10:16
3839151 to
bc1a7d4
Compare
gentledepp
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.