feat(export): pick the video encoder from the host's hardware, with a libx264 fallback#161
Draft
EtienneLescot wants to merge 2 commits into
Draft
feat(export): pick the video encoder from the host's hardware, with a libx264 fallback#161EtienneLescot wants to merge 2 commits into
EtienneLescot wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 26, 2026 15:36
b43adda to
92fbe07
Compare
EtienneLescot
force-pushed
the
feat/native-encoder-vendor-selection
branch
from
July 26, 2026 15:36
7ea22fd to
f01df9e
Compare
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 27, 2026 06:28
2bb4058 to
f7a020d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
poc-d3d/src/pipeline.rshard-codes the AMD encoder in three places —:250,:637and:755— and refuses to continue without it:AMF is AMD-only. On an NVIDIA or Intel host, or on any machine without a hardware H.264 encoder, this path cannot open an encoder at all — native export fails outright rather than degrading.
Development happens on an AMD GPU, which is exactly why this has stayed invisible.
What already exists
electron/media/ffmpegCapabilities.tsalready probes the ffmpeg binary for its real encoder list, and its tests coverh264_qsv,h264_amf,h264_nvenc,h264_videotoolboxandlibx264. The discovery is there — the Rust pipeline simply never consults it.Scope
libx264last).fix(export): prove the encoder works instead of inferring it from -encodersestablished that lesson on the Electron side.Out of scope
preferSoftwareEncoderoverride — separate PR.Acceptance
libx264.