feat(compositor): fall back to a WARP device when D3D11 hardware init fails#162
Draft
EtienneLescot wants to merge 2 commits into
Draft
feat(compositor): fall back to a WARP device when D3D11 hardware init fails#162EtienneLescot wants to merge 2 commits into
EtienneLescot wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 26, 2026 15:36
b43adda to
92fbe07
Compare
EtienneLescot
force-pushed
the
feat/d3d-warp-fallback
branch
from
July 26, 2026 15:36
d65c424 to
343ec07
Compare
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 27, 2026 06:28
2bb4058 to
f7a020d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Both D3D11 devices are created hardware-only, with no fallback:
poc-d3d/src/d3d.rs:43—D3D11CreateDevice(..., D3D_DRIVER_TYPE_HARDWARE, ...), thenbail!if the returned feature level is not11_1.electron/native/wgc-capture/src/wgc_session.cpp:79— same driver type.So on a VM, over RDP, on a machine whose GPU does not reach feature level 11_1, or after a driver fault, the compositor does not start. It fails; it does not degrade.
This matters more than it used to:
refactor(preview): remove the CPU and web fallbacks — one native pathdeliberately removed the preview's software route. There is now nothing behind the native path.Scope
D3D_DRIVER_TYPE_WARPwhen the hardware attempt fails.Open questions to settle in review
Depends on
Nothing blocking, but it shares a reflex with the encoder-selection PR: detect what the host actually offers, then degrade deliberately. Landing that one first would set the pattern.