feat(settings): expose the software-encoder preference in the UI#163
Draft
EtienneLescot wants to merge 3 commits into
Draft
feat(settings): expose the software-encoder preference in the UI#163EtienneLescot wants to merge 3 commits into
EtienneLescot wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 26, 2026 15:36
b43adda to
92fbe07
Compare
EtienneLescot
force-pushed
the
feat/software-encoder-toggle-ui
branch
from
July 26, 2026 15:36
f6a8ab9 to
5ee6ca6
Compare
EtienneLescot
force-pushed
the
release/1.8.0
branch
from
July 27, 2026 06:28
2bb4058 to
f7a020d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The preference already exists end to end, but nothing lets a user set it.
src/lib/userPreferences.ts:26and:39src/hooks/useScreenRecorder.ts:843src/lib/nativeWindowsRecording.ts:5src/lib/userPreferences.test.ts:108-119But no
.tsxfile referencespreferSoftwareEncoderanywhere. The only way to turn it on today is to hand-edit localStorage.Scope
Semantics worth getting right in the copy
This is an override, not a selector: "use the software encoder even when a hardware one is available". It exists for hosts where the hardware encoder produces corrupt output or fails, which is a real class of driver bug.
That is a different thing from the automatic, hardware-derived encoder choice in the export-encoder PR — the UI wording should not lead a user to think this is how the app normally decides. Expect it to live under an advanced or troubleshooting section rather than in the main recording settings.