test(github): normalize semver tags in latest_github_release_version#1160
Merged
Conversation
The isolated mise global config used by these tests did not declare wait-for-gh-rate-limit, so run_mise emitted "No version is set for shim: wait-for-gh-rate-limit" while installing the test tool. Declare it (pinned to match mise.devbase.toml) to keep the test output clean. Assisted-By: Claude Opus 4.8 via opencode
mise 2026.6.14+ normalizes the leading `v` away when installing a pre-release GitHub tag (e.g. v1.2.3-rc.1 becomes 1.2.3-rc.1) but re-adds it during `mise which`/`mise where` resolution, so the freshly-installed tool resolves as not installed/inactive. This broke install_latest_github_release for pre-release tags (observed as the test-macos failure installing stencil) and affects any v-prefixed pre-release GitHub tool resolved through mise_exec_tool. Strip the leading `v` before handing the version to mise, only before a digit so non-semver tags are untouched. The stencil install tests also assert the binary runs. Assisted-By: Claude Opus 4.8 via opencode
Merged
3 tasks
ekalinichev
approved these changes
Jul 10, 2026
|
🎉 This PR is included in version 2.39.0-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
test-macosfails deterministically wheninstall_latest_github_releaseinstalls a pre-release tag (stencil). The cause is an upstream mise bug: on mise2026.6.14+, installing a GitHub tool with av-prefixed pre-release tag such asv1.44.0-rc.3records the install under thev-stripped version but leaves a stalev-prefixed entry, somise which/mise whereresolve the requestedv-form and report the freshly-installed tool as not installed. It affects anyv-prefixed pre-release GitHub tool resolved throughmise_exec_tool; stablev-prefixed tags are unaffected.latest_github_release_versionnow strips a leadingv(only before a digit) so callers receive a normalized version.circleci-orb-sync, its only other consumer, previously relied on the leadingv; it now normalizes the stencil.lock-sourced version the same way and classifies on thev-less form, preserving its existing orb-version output.