fix(gcs): Retry multipart operations - #575
Merged
Merged
Conversation
Wrap initiate, list, and abort in the existing GCS request retry helper so transient 5xx/transport failures are absorbed internally. Leave put-part and complete unretried for now (streamed body / separate PR). Make abort idempotent on 404 after a lost successful response.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 87.53% 87.71% +0.17%
==========================================
Files 93 94 +1
Lines 15283 15505 +222
==========================================
+ Hits 13378 13600 +222
Misses 1905 1905
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
marked this pull request as ready for review
July 24, 2026 14:59
jan-auer
reviewed
Jul 27, 2026
jan-auer
approved these changes
Jul 27, 2026
jan-auer
left a comment
jan-auer
left a comment
Member
There was a problem hiding this comment.
LGTM. Please add complete, too.
lcian
changed the title
lcian
enabled auto-merge (squash)
July 27, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retryable GCS multipart operations now go through the same request-level retry helper already used by the JSON API path, so transient transport/
5xxfailures are absorbed inside the backend instead of bouncing to callers.Supersedes #566
Closes FS-450
Fixes OBJECTSTORE-3XB