Skip to content

fix: Minor improvement in error handling - #576

Merged
jan-auer merged 1 commit into
mainfrom
fix/minor-error-handling
Jul 27, 2026
Merged

fix: Minor improvement in error handling#576
jan-auer merged 1 commit into
mainfrom
fix/minor-error-handling

Conversation

@jan-auer

Copy link
Copy Markdown
Member

Two unrelated improvements that were found while working on other features:

  1. Improve the expect when creating the backend HTTP client. This will panic
    regardless, but improves the error message.
  2. Log a warning when parsing the Sentry DSN fails. This makes it easier to
    investigate when no data turns up in Sentry.

@jan-auer
jan-auer requested a review from a team as a code owner July 27, 2026 11:26
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.62%. Comparing base (181df0a) to head (ae9b45d).

Files with missing lines Patch % Lines
objectstore-server/src/observability.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   87.64%   87.62%   -0.03%     
==========================================
  Files          94       94              
  Lines       15425    15430       +5     
==========================================
  Hits        13520    13520              
- Misses       1905     1910       +5     
Components Coverage Δ
Rust Backend 92.31% <14.28%> (-0.04%) ⬇️
Rust Client 79.89% <ø> (ø)
Python Client 90.90% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit 7a02b94 into main Jul 27, 2026
26 checks passed
@jan-auer
jan-auer deleted the fix/minor-error-handling branch July 27, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants