Skip to content

test(server): Fix flaky test_bandwidth_burst_tolerance #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-auer merged 1 commit into from
Jul 27, 2026
+7 −6
Merged

test(server): Fix flaky test_bandwidth_burst_tolerance #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions objectstore-server/tests/limits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,17 +398,18 @@ async fn test_bandwidth_global_bps_limit() -> Result<()> {

#[tokio::test]
async fn test_bandwidth_burst_tolerance() -> Result<()> {
// 100 bps with 1.5s burst → burst budget = 150 bytes.
// A 100-byte upload creates 1s of debt, within 1.5s burst → next request admitted.
// 10 bps with 10s burst → burst budget = exactly one 100-byte upload.
// The rate is deliberately slow so that each upload creates 10s of debt: the third
// request stays rejected for a full 10s, independent of CI scheduling delays.
let server = TestServer::with_config(Config {
auth: AuthZ {
enforce: false,
..Default::default()
},
rate_limits: RateLimits {
bandwidth: BandwidthLimits {
global_bps: Some(100),
burst_ms: 1500,
global_bps: Some(10),
burst_ms: 10_000,
..Default::default()
},
..Default::default()
Expand All @@ -420,7 +421,7 @@ async fn test_bandwidth_burst_tolerance() -> Result<()> {
let client = reqwest::Client::new();
let payload = vec![0xABu8; 100];

// First upload creates 1s of debt, within the 1.5s burst tolerance.
// First upload creates 10s of debt, within the 10s burst tolerance.
let response = client
.post(server.url("/v1/objects/test/org=1/"))
.body(payload.clone())
Expand All @@ -436,7 +437,7 @@ async fn test_bandwidth_burst_tolerance() -> Result<()> {
.await?;
assert_eq!(response.status(), reqwest::StatusCode::CREATED);

// Now debt ≈ 2s > 1.5s burst → rejected.
// Now debt ≈ 20s > 10s burst → rejected.
let response = client
.post(server.url("/v1/objects/test/org=1/"))
.body(payload.clone())
Expand Down
Loading