Skip to content

ci: Set Renovate commit type so dep bumps skip the changelog #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Jun 23, 2026
Merged

ci: Set Renovate commit type so dep bumps skip the changelog #1317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,25 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:recommended"
],
"semanticCommits": "enabled",
"semanticCommitType": "build",
"semanticCommitScope": "deps",
"packageRules": [
{
"description": "The Sentry SDK is bumped by the update-deps workflow's updater action, which writes its own CHANGELOG entry. Letting Renovate update it too would create duplicate PRs.",
"matchPackageNames": [
"io.sentry:sentry"
],
"enabled": false
Comment on lines +12 to +15

@sentry sentry Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The Renovate rule only disables io.sentry:sentry, but other io.sentry:* packages share the same version reference. This could lead to duplicate PRs if those packages are used later.
Severity: LOW

Suggested Fix

Broaden the Renovate rule to cover all io.sentry packages. Use a wildcard pattern like "io.sentry:*" or a regex in the matchPackageNames field to ensure all related Sentry dependencies are disabled from Renovate's automated updates, aligning with the intent to manage them via the custom workflow.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: renovate.json#L12-L15

Potential issue: The Renovate configuration change only disables automated dependency
updates for the `io.sentry:sentry` package. However, the Gradle version catalog defines
other Sentry packages (`sentry-android`, `sentry-okhttp`) that share the same version
reference. A custom workflow is responsible for updating this shared version. Because
the Renovate rule is too specific, if any of the other Sentry packages are added as
dependencies in the future, Renovate will create a separate, duplicate pull request for
them, conflicting with the custom update workflow. This is a latent configuration issue
that poses a future maintenance risk.

Did we get this right? 👍 / 👎 to inform future reviews.

@runningcode runningcode Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only io.sentry:sentry is shipped with the gradle plugin so this is correct.

@romtsn romtsn Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's valid, I guess?

},
{
"description": "Deps bundled into the published plugin are user-facing, so use a fix: title to make Danger require a CHANGELOG entry. Everything else stays build(deps): and is skipped.",
"matchPackageNames": [
"org.ow2.asm:asm-util",
"org.ow2.asm:asm-commons"
],
"semanticCommitType": "fix"
}
]
}
Loading