build(deps): Skip NDK sample during Renovate lockfile updates - #1368
Open
runningcode wants to merge 1 commit into
Open
build(deps): Skip NDK sample during Renovate lockfile updates#1368runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
July 21, 2026 15:00
Renovate regenerates the Gradle lockfile using the root gradlew, which evaluates the root settings and includes the android-ndk sample. Configuring that sample makes AGP set up the NDK, which is absent in Renovate's environment, so dependency bumps failed while relocking and left a stale lockfile that then broke the PR build. Skip the sample on dependency-resolution runs, detected from Gradle's own start parameters: Renovate always passes --write-locks/--update-locks and --dependency-verification lenient, none of which normal dev and CI builds use. The sample is never needed to resolve dependencies, so this keeps every other build unchanged without relying on a custom env var (which would need Mend to allowlist it via allowedEnv). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/renovate-disable-ndk
branch
from
July 21, 2026 15:07
9d79eca to
c33ae86
Compare
romtsn
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate updates a dependency and then regenerates the Gradle lockfile. Since the changed dependency lives in the root
gradle/libs.versions.toml, Renovate runs the rootgradlew, which evaluates the rootsettings.gradle.ktsand includes:examples:android-ndk. Configuring that sample makes AGP set up the NDK — which isn't available in Renovate's environment — so the relock fails, leaving a stale lockfile that then breaks the PR build (e.g. #1363).The
android-ndksample is never needed to resolve dependencies, so this skips it on dependency-resolution runs. Rather than a custom env var (which Renovate only forwards if a bot admin allowlists it viaallowedEnv), the sample is gated on Gradle's own start parameters: Renovate always invokes Gradle with--write-locks/--update-locksand--dependency-verification lenient, none of which normal dev and CI builds use. So those builds still build the sample, and the fix needs no Renovate/Mend configuration.#skip-changelog
🤖 Generated with Claude Code