Skip to content

docs: Fix stale pod-install script names in CONTRIBUTING #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Fix stale pod-install script names in CONTRIBUTING #6495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,32 +82,34 @@ Recommended is to open the native project in `samples/react-native/android` and
For android switch `newArchEnabled` to `false` in [android/gradle.properties](https://github.com/getsentry/sentry-react-native/blob/c95aa21497ca93aaaaf0b44d170dc39dc7bcf660/sample-new-architecture/android/gradle.properties#L40). For iOS explicitly disable fabric in `samples/react-native/ios/Podfile` by setting `:fabric_enabled => false` before `pod install`.

```sh
yarn pod-install-legacy
yarn pod-install-debug-static-legacy
yarn react-native run-ios

yarn react-native run-android

# Release builds
yarn pod-install-legacy-production
yarn pod-install-release-static-legacy
yarn react-native run-ios --mode=Release

yarn react-native run-android --mode=release
```

### Run the emulators (new-architecture):
```sh
yarn pod-install
yarn pod-install-debug-static
yarn react-native run-ios

yarn react-native run-android

# Release builds
yarn pod-install-production
yarn pod-install-release-static
yarn react-native run-ios --mode=Release

yarn react-native run-android --mode=Release
```

The `pod-install-*` scripts follow the pattern `pod-install-{debug,release}-{static,dynamic}[-legacy]` (dynamic variants build with frameworks as dynamic libraries). Since [#6413](https://github.com/getsentry/sentry-react-native/pull/6413), `pod install` downloads a prebuilt `Sentry.xcframework` from sentry-cocoa's GitHub release and vendors it, instead of building Sentry from source. Set `SENTRY_USE_XCFRAMEWORK=0` before `pod install` to restore the previous source-build behavior (e.g. for offline builds).

## Running the macOS sample

Head to the macOS sample root directory:
Expand Down
Loading