Skip to content

fix: resolved ReadOnlySpan missing#2754

Merged
bitsandfoxes merged 8 commits into
mainfrom
fix/bcl-dependenies
Jul 8, 2026
Merged

fix: resolved ReadOnlySpan missing#2754
bitsandfoxes merged 8 commits into
mainfrom
fix/bcl-dependenies

Conversation

@bitsandfoxes

@bitsandfoxes bitsandfoxes commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Addresses #2751

We excluded those libraries from being aliased in #2726.
This had the side effect of also setting the PublicKeyToken to null. When users would call EmitCounter<T>(string name, T value, ReadOnlySpan<KeyValuePair<string, object>> attributes). this would cause

error CS0012: The type 'ReadOnlySpan<>' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Memory, Version=4.0.1.2, Culture=neutral, PublicKeyToken=null'.

Since we're already not aliasing those assemblies and we let Unity handle the resolution, we can simply rely on what Unity already comes with.

@bitsandfoxes bitsandfoxes marked this pull request as ready for review July 8, 2026 11:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6647637. Configure here.

Comment thread samples/unity-of-bugs/Assets/Scripts/BugFarmButtons.cs
@bitsandfoxes bitsandfoxes requested a review from a team July 8, 2026 12:22

@JoshuaMoelans JoshuaMoelans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bitsandfoxes bitsandfoxes merged commit 8121e25 into main Jul 8, 2026
112 of 116 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/bcl-dependenies branch July 8, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants