Skip to content

Upgrade js-yaml to v5.1.0 and migrate to Vitest from Jest#215

Merged
JoyceZhu merged 2 commits into
mainfrom
copilot/update-js-yaml-markdown-it
Jun 24, 2026
Merged

Upgrade js-yaml to v5.1.0 and migrate to Vitest from Jest#215
JoyceZhu merged 2 commits into
mainfrom
copilot/update-js-yaml-markdown-it

Conversation

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Bumps js-yaml to the new v5 line and confirms markdown-it meets the ≥14.2.0 requirement.

Changes

  • js-yaml ^5.1.0 added as a direct devDependency, hoisting js-yaml@5.1.0 to the root of node_modules (was 4.1.1 via transitive hoisting from @eslint/eslintrc and markdownlint-cli2)
  • markdown-it already pinned at 14.2.0 as a direct dependency — no change required

Remaining nested older versions

These transitive consumers still resolve older nested copies. All are at their latest published versions; no upgrade path exists without npm overrides.

Package Nested dep
markdownlint-cli2@0.22.1 markdown-it@14.1.1
@eslint/eslintrc@3.3.5 (via eslint) js-yaml@4.2.0
@istanbuljs/load-nyc-config@1.1.0 (via jest → @jest/transform → babel-plugin-istanbul) js-yaml@3.14.2

Copilot AI changed the title Upgrade js-yaml to ^5.1.0 and ensure markdown-it is at 14.2.0 Upgrade js-yaml to v5.1.0; markdown-it already at 14.2.0 Jun 24, 2026
GitHub Advanced Security started work on behalf of JoyceZhu June 24, 2026 18:41 View session
Copilot AI requested a review from JoyceZhu June 24, 2026 18:41
GitHub Advanced Security finished work on behalf of JoyceZhu June 24, 2026 18:41
@JoyceZhu JoyceZhu marked this pull request as ready for review June 24, 2026 18:46
@JoyceZhu JoyceZhu requested a review from a team as a code owner June 24, 2026 18:46
Copilot AI review requested due to automatic review settings June 24, 2026 18:46
@JoyceZhu

Copy link
Copy Markdown
Contributor

@copilot, can you try migrating Jest to Vitest to get rid of the @istanbuljs/load-nyc-config dependency?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Node dependency graph to ensure js-yaml@5.1.0 is installed at the workspace root (as a direct devDependency) and refreshes the lockfile accordingly, while confirming markdown-it already satisfies the stated version requirement.

Changes:

  • Add js-yaml ^5.1.0 as a direct devDependency in package.json.
  • Update package-lock.json to reflect js-yaml@5.1.0 at the root and corresponding dependency tree adjustments.
  • Update the lockfile’s recorded root engines.node range (as part of the lockfile update).
Show a summary per file
File Description
package.json Adds js-yaml as a direct dev dependency to pull in v5.x at the root.
package-lock.json Updates the resolved dependency tree for js-yaml and adjusts recorded root package metadata (including engines).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/2 changed files
  • Comments generated: 0

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot, can you try migrating Jest to Vitest to get rid of the @istanbuljs/load-nyc-config dependency?

Done in the latest commit. Here's what changed:

  • jest removed from devDependencies; vitest ^4.1.9 added in its place
  • jest.config.json removed; vitest.config.js added (globals: true so test files need no import changes)
  • Test script simplified from NODE_OPTIONS=--experimental-vm-modules jestvitest run (Vitest handles ESM natively)
  • overrides["@babel/core"] removed — it was only needed by Jest's Babel transform pipeline
  • eslint.config.js updated: globals.jestglobals.vitest, and vitest added to the import/no-unresolved ignore list

All 21 tests pass and linting is clean.

GitHub Advanced Security started work on behalf of JoyceZhu June 24, 2026 18:53 View session
GitHub Advanced Security finished work on behalf of JoyceZhu June 24, 2026 18:54
@JoyceZhu JoyceZhu changed the title Upgrade js-yaml to v5.1.0; markdown-it already at 14.2.0 Upgrade js-yaml to v5.1.0 and migrate to Vitest from Jest Jun 24, 2026
@JoyceZhu JoyceZhu merged commit fee9c46 into main Jun 24, 2026
6 checks passed
@JoyceZhu JoyceZhu deleted the copilot/update-js-yaml-markdown-it branch June 24, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants