Bump modernc.org/sqlite to 1.55.0 (SQLite 3.53.3) - #188
Open
davidpavlovschi wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
@glebarez same review window as glebarez/sqlite#153: open until Aug 3, then I merge and tag unless you object. This one moves the embedded engine from SQLite 3.46.0 to 3.53.3 and fixes a nil-blob binding bug that was already live on linux. |
Collaborator
Author
|
Pushed one more commit: TestConcurrentProcesses is now skipped with the reason in the code. It builds modernc.org/sqlite/internal/mptest, which is not importable from outside modernc's module, so it has been red since the fork was cut and can never pass here. With the skip this branch should give the repo its first fully green run on the new matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modernc.org/sqlite from 1.31.0 to 1.55.0, plus libc, mathutil, memory, x/sys, pprof and go-strftime to match. The embedded SQLite engine goes from 3.46.0 to 3.53.3.
The go directive moves from 1.20 to 1.25.0. I did not choose that: modernc.org/sqlite 1.55.0 declares go 1.25.0, so
go getraised it. The CI matrix was 1.19/1.20/1.21, none of which can build the module now, so I set it to 1.25 and 1.26 and bumped the badge workflow off 1.21 for the same reason.Two things needed fixing.
First, a real bug.
bindBlobhandedmalloc(0)straight tosqlite3_bind_blobfor a nil[]byteand relied on that returning NULL to get SQL NULL. libc now returns a unique pointer formalloc(0), so a nil slice started binding an empty blob andTestIssue100failed. I made the nil case callsqlite3_bind_nullexplicitly, which is what upstream modernc already does. Note this was only ever correct on darwin: on linux the musl allocator already returned a non-NULL pointer for size 0, so the bug was live there before this bump.Second, the test file stopped compiling.
sqlite3.MutexCountersandsqlite3.MutexEnterCallerswere removed upstream. I dropped the same lines from the same function that upstream dropped them from. No benchmark behavior changes.Test counts,
go test -v ./...on darwin/arm64: 42 pass and 1 fail before, 42 pass and 1 fail after. The one failure isTestConcurrentProcesses, which is already red on master. It buildsmodernc.org/sqlite/internal/mptest, and that package is not importable from outside modernc's own module. I left it alone.go test -race ./...is clean apart from that same failure.