docs: document "has multiple values" response type in Wait for Response#640
docs: document "has multiple values" response type in Wait for Response#640SangeetaMishr wants to merge 4 commits into
Conversation
Explains how it differs from "has any of the words" and adds a comparison example, per user question in #399. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change updates a documentation file for the “Wait for the contact to respond” flow action. It changes the “Last Updated” date from October 2025 to July 2026. It also adds a new “5. has multiple values” subsection under Text-based responses, documenting the validation rule, its contrast with “has any of the words,” and an example with a screenshot. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-640--glific-docs.netlify.app |
Remove bold/backticks/table formatting per review feedback, keep plain sentences followed by the screenshot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keep the read-time/level/date header untouched per review feedback so the diff only shows the new section. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md:
- Around line 77-87: Clarify the “has multiple values” section by describing it
as an all-tokens/subset match: every word in the contact’s reply must be present
in the configured criteria, and any extra word makes it invalid. Update the
wording in the “has multiple values” docs to make the usage boundary explicit
versus “has any of the words,” and specify whether commas are only used to
separate the criteria values or also expected in the contact response.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 86f07c55-53c9-407b-92da-8d3d451fb976
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md
| ### 5. has multiple values | ||
| Accepts the input only if every word in the response is one of the values defined in the response criteria. Multiple values can be added, separated by commas, and the response is checked the same way. | ||
|
|
||
| The contact does not need to send every value from the list and can send them in any order, but the response is valid only if all the words in it come from the defined list. If the response includes even one word that is not in the list, it is treated as invalid. | ||
|
|
||
| This is the opposite of has any of the words, which accepts the response if even a single word matches, regardless of the rest of the response. | ||
|
|
||
| Example: Criteria = Math, Science, English, History. A response of Math or Math, Science will be valid. A response of Math, Art will be invalid since Art is not part of the criteria, even though has any of the words would accept it because Math matches. | ||
|
|
||
| <img width="1870" height="1320" alt="Wait for Response node showing the has multiple values option" src="https://github.com/user-attachments/assets/76c8f4ad-707e-4ece-bac0-f1acee14f911" /> | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Clarify the semantics and when to use this option.
The new text explains the rule, but "opposite of has any of the words" is too loose, and the section still doesn’t spell out the intended usage boundary. Please make the comparison explicit as a subset/all-tokens check and confirm whether commas apply only to the criteria list or also to the contact’s reply.
♻️ Proposed wording
-### 5. has multiple values
-Accepts the input only if every word in the response is one of the values defined in the response criteria. Multiple values can be added, separated by commas, and the response is checked the same way.
-
-The contact does not need to send every value from the list and can send them in any order, but the response is valid only if all the words in it come from the defined list. If the response includes even one word that is not in the list, it is treated as invalid.
-
-This is the opposite of has any of the words, which accepts the response if even a single word matches, regardless of the rest of the response.
+### 5. has multiple values
+Use this option when the reply should be limited to a predefined set of values. It accepts the input only if every word in the response is one of the values defined in the response criteria. Criteria values can be entered as a comma-separated list.
+
+The contact does not need to send every value from the list and can send them in any order, but the response is valid only if all words in it come from the defined list. If the response includes even one word that is not in the list, it is invalid.
+
+This differs from has any of the words, which accepts the response if even a single word matches, regardless of the rest of the response.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### 5. has multiple values | |
| Accepts the input only if every word in the response is one of the values defined in the response criteria. Multiple values can be added, separated by commas, and the response is checked the same way. | |
| The contact does not need to send every value from the list and can send them in any order, but the response is valid only if all the words in it come from the defined list. If the response includes even one word that is not in the list, it is treated as invalid. | |
| This is the opposite of has any of the words, which accepts the response if even a single word matches, regardless of the rest of the response. | |
| Example: Criteria = Math, Science, English, History. A response of Math or Math, Science will be valid. A response of Math, Art will be invalid since Art is not part of the criteria, even though has any of the words would accept it because Math matches. | |
| <img width="1870" height="1320" alt="Wait for Response node showing the has multiple values option" src="https://github.com/user-attachments/assets/76c8f4ad-707e-4ece-bac0-f1acee14f911" /> | |
| ### 5. has multiple values | |
| Use this option when the reply should be limited to a predefined set of values. It accepts the input only if every word in the response is one of the values defined in the response criteria. Criteria values can be entered as a comma-separated list. | |
| The contact does not need to send every value from the list and can send them in any order, but the response is valid only if all words in it come from the defined list. If the response includes even one word that is not in the list, it is invalid. | |
| This differs from has any of the words, which accepts the response if even a single word matches, regardless of the rest of the response. | |
| <img width="1870" height="1320" alt="Wait for Response node showing the has multiple values option" src="https://github.com/user-attachments/assets/76c8f4ad-707e-4ece-bac0-f1acee14f911" /> |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 77-77: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md around lines 77 - 87, Clarify the “has multiple values” section by
describing it as an all-tokens/subset match: every word in the contact’s reply
must be present in the configured criteria, and any extra word makes it invalid.
Update the wording in the “has multiple values” docs to make the usage boundary
explicit versus “has any of the words,” and specify whether commas are only used
to separate the criteria values or also expected in the contact response.
Summary
Fixes #399
The
Wait for Responsenode's "Response Type" dropdown has ahas multiple valuesoption that wasn't documented at all. This adds a "5. has multiple values" subsection under Text-based responses, explaining:has all of the words)has any of the words(which only needs one matching word)Verification
The behavior is described directly from the matching logic in
glific/glific:lib/glific/flows/case.ex(do_execute(%{type: "has_multiple"} ...), usingMapSet.subset?/2)lib/glific.ex(Glific.make_set/2, which shows criteria/replies are split on commas, semicolons, and whitespace, case-insensitively)test/glific/flows/case_test.exs("test the execute function for has_multiple"), which confirms the subset behaviorTest plan
Summary by CodeRabbit