Skip to content

ci: test on Go 1.24 through 1.26 - #240

Merged
jinzhu merged 1 commit into
go-gorm:masterfrom
h2zi:ci-go-1.21-1.26
Jul 31, 2026
Merged

ci: test on Go 1.24 through 1.26#240
jinzhu merged 1 commit into
go-gorm:masterfrom
h2zi:ci-go-1.21-1.26

Conversation

@h2zi

@h2zi h2zi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Why

CI is currently red on master and on every PR: the matrix still includes Go 1.19 and 1.20, which are below the go 1.21 requirement in go.mod and no longer compile the driver — github.com/mattn/go-sqlite3 v1.14.48 (bumped in #239) uses unsafe.StringData, which was added in Go 1.20:

../go-sqlite3@v1.14.48/sqlite3.go:2196:68: undefined: unsafe.StringData
FAIL    gorm.io/driver/sqlite [build failed]

Example failing runs: master, #236.

What

Update the matrix to the three most recent Go releases: 1.24, 1.25, 1.26.

🤖 Generated with Claude Code

The matrix still includes Go 1.19 and 1.20, which are below the
`go 1.21` requirement in go.mod and no longer compile the driver:
github.com/mattn/go-sqlite3 v1.14.48 (bumped in go-gorm#239) uses
unsafe.StringData, added in Go 1.20, so the 1.19 job fails on master
and on every PR. Test the three most recent releases instead.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflow to stop testing unsupported Go versions and instead run tests against newer Go releases, aligning CI with the project’s current Go toolchain expectations.

Changes:

  • Update the CI Go version matrix from Go 1.19–1.21 to Go 1.24–1.26.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
@jinzhu
jinzhu merged commit 525c431 into go-gorm:master Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants