fix(ddlmod): parse parameterized types with precision like decimal(10,2) - #245
Open
h2zi wants to merge 1 commit into
Open
fix(ddlmod): parse parameterized types with precision like decimal(10,2)#245h2zi wants to merge 1 commit into
h2zi wants to merge 1 commit into
Conversation
The type group of columnRegexp had no comma, so `decimal(10,2)` was truncated to `decimal(10` in ColumnType(), and the scale was lost. The type group now takes the whole parenthesized parameter list, and the size parsing distinguishes a single length (varchar(10) -> Length) from precision and scale (decimal(10,2) -> DecimalSize/Scale), spaces after the comma included.
This was referenced Jul 31, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes SQLite DDL parsing so parameterized column types that include commas (e.g. decimal(10,2)) are captured and interpreted correctly by the migrator’s ColumnTypes()/ColumnType()/size helpers.
Changes:
- Updates
columnRegexpto capture a full parenthesized type parameter list (including commas) instead of truncating at the first comma. - Replaces the previous numeric-suffix extraction with a dedicated
typeSizeRegexpthat parses eitherlengthorprecision,scale. - Adds
TestParseDDL_TypePrecisionto validatedecimal(10,2),decimal(10, 2), andvarchar(25)behavior, including preservation of fullColumnType().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ddlmod.go | Improves type tokenization and parses (len) vs (precision,scale) using a dedicated regexp. |
| ddlmod_test.go | Adds a regression test ensuring decimal precision/scale and full column type strings are preserved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
For a column declared
decimal(10,2),ColumnTypes()reportsColumnType() == "decimal(10"— the type group ofcolumnRegexp([\w\(\)\d]+) has no comma, so the match stops inside the parameter list and the scale is lost entirely (related: #121).Fix
\w+(?:\([^)]*\))?.varchar(10)→Length() == 10as before,decimal(10,2)(anddecimal(10, 2)) →DecimalSize() == (10, 2), withDataType() == "decimal"and the fullColumnType()preserved.Covered by
TestParseDDL_TypePrecision.🤖 Generated with Claude Code
Merge order (this batch: #241 → #242 → #243 → #244 → #245 → #246, plus #234 from the previous batch): all seven are functionally independent and merge cleanly in any order. Several append tests to the same test files, so whichever merges later may show a trivial append-only conflict in
migrator_test.go/ddlmod_test.go— I'll rebase the remaining ones promptly after each merge, as before.