ci: go 1.26, golangci-lint v2.12, address new gosec findings#300
Open
paskal wants to merge 5 commits into
Open
ci: go 1.26, golangci-lint v2.12, address new gosec findings#300paskal wants to merge 5 commits into
paskal wants to merge 5 commits into
Conversation
- set image/png content type on generated avatar endpoints - suppress false positives with reasons: config-driven cookie attrs, oauth endpoint urls flagged as credentials, fixed-host apple redirect, store-generated avatar paths - exclude gosec in test files via config
- mirror apple redirect nolint to v2 to keep modules in sync - set explicit branches/tags match-all on push triggers, actionlint flags the empty form - use --config= form for golangci-lint-action v9 args
Coverage Report for CI Build 29077894154Coverage increased (+0.009%) to 85.454%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Coverage Report for CI Build 29079091071Coverage increased (+0.009%) to 85.454%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI pinned go 1.24 while all three modules require 1.25 since #297, which made the example build fail on every dependabot PR until toolchain auto-download kicked in, and golangci-lint v2.6.2 panics on the go 1.26 stdlib.
Changes:
golangci-lintv2.6.2 → v2.12.2,golangci-lint-actionv7 → v9 (v8/v9 have no breaking config changes, node runtime only),--config=form for argsbranches: ["**"]/tags: ["**"]instead of empty keys flagged by actionlintcheckoutv4 → v7,codeql-actionv3 (deprecated) → v4; quoted$GITHUB_WORKSPACEin run scripts, actionlint now fully clean (start-mongoDB@v0.2is already latest)dev_provider.go,custom_server.go) now setContent-Type: image/pngbefore writing the generated identicontoken/jwt.gocookies (Secure/SameSite come from service config, XSRF cookie is JS-readable by design),provider/providers.gooauth endpoint urls flagged as hardcoded credentials (G101),provider/apple.goredirect to the fixed apple auth endpoint (G710),avatar/localfs.gostore-generated paths (G703)_test.gofiles via.golangci.ymlavatar/avatar_test.go(pre-existing comment alignment drift)Both modules lint clean with v2.12.2, tests pass with
-race, example builds.go fix ./...produced no changes.