Skip to content

ak-sysd: migrate to rust - #1262

Open
BeryJu wants to merge 116 commits into
mainfrom
ak-sysd
Open

ak-sysd: migrate to rust#1262
BeryJu wants to merge 116 commits into
mainfrom
ak-sysd

Conversation

@BeryJu

@BeryJu BeryJu commented Jul 25, 2026

Copy link
Copy Markdown
Member

No description provided.

@BeryJu
BeryJu marked this pull request as draft July 25, 2026 20:16
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.75047% with 2112 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.69%. Comparing base (0738065) to head (cb494dc).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ak-sysd/src/cfg/domain.rs 44.00% 171 Missing and 11 partials ⚠️
ak-sysd/src/check/mod.rs 0.00% 150 Missing ⚠️
ak-sysd/src/agent.rs 0.00% 132 Missing ⚠️
ak-sysd/src/components/agent_starter/mod.rs 0.00% 115 Missing ⚠️
ak-sysd/src/runner.rs 0.00% 112 Missing ⚠️
ak-sysd/src/components/agent_starter/win.rs 0.00% 95 Missing ⚠️
ak-sysd/src/components/auth/interactive/mod.rs 3.06% 95 Missing ⚠️
ak-sysd/src/state/sessions.rs 0.00% 89 Missing ⚠️
ak-sysd/src/components/session/mod.rs 0.00% 88 Missing ⚠️
ak-platform/src/tui.rs 0.00% 85 Missing ⚠️
... and 41 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   28.14%   25.69%   -2.46%     
==========================================
  Files         240      151      -89     
  Lines       14443     9019    -5424     
  Branches     1528     8372    +6844     
==========================================
- Hits         4065     2317    -1748     
+ Misses      10064     6583    -3481     
+ Partials      314      119     -195     
Flag Coverage Δ
go-integration ?
go-macos-26 ?
go-ubuntu-24.04 ?
go-ubuntu-24.04-arm ?
go-windows-2025 ?
rs-e2e ?
rs-macos-26-ak-agent 4.55% <0.00%> (?)
rs-macos-26-ak-agent-desktop 0.00% <0.00%> (?)
rs-macos-26-ak-api-cli-gen 66.71% <ø> (?)
rs-macos-26-ak-browser-support 23.80% <0.00%> (?)
rs-macos-26-ak-cli 12.10% <0.00%> (?)
rs-macos-26-ak-platform 0.32% <0.00%> (?)
rs-macos-26-ak-platform-facts 83.96% <90.62%> (?)
rs-macos-26-ak-sysd 24.10% <24.10%> (?)
rs-ubuntu-24.04-ak-agent 4.55% <0.00%> (?)
rs-ubuntu-24.04-ak-agent-desktop 0.00% <0.00%> (?)
rs-ubuntu-24.04-ak-api-cli-gen 66.71% <ø> (?)
rs-ubuntu-24.04-ak-browser-support 23.80% <0.00%> (?)
rs-ubuntu-24.04-ak-cli 12.10% <0.00%> (?)
rs-ubuntu-24.04-ak-nss 77.57% <ø> (?)
rs-ubuntu-24.04-ak-pam 0.00% <ø> (?)
rs-ubuntu-24.04-ak-platform 0.32% <0.00%> (?)
rs-ubuntu-24.04-ak-platform-facts 83.14% <86.11%> (?)
rs-ubuntu-24.04-ak-sysd 24.08% <24.08%> (?)
rs-ubuntu-24.04-arm-ak-agent 4.55% <0.00%> (?)
rs-ubuntu-24.04-arm-ak-agent-desktop 0.00% <0.00%> (?)
rs-ubuntu-24.04-arm-ak-api-cli-gen 66.71% <ø> (?)
rs-ubuntu-24.04-arm-ak-browser-support 23.80% <0.00%> (?)
rs-ubuntu-24.04-arm-ak-cli 12.10% <0.00%> (?)
rs-ubuntu-24.04-arm-ak-nss 77.57% <ø> (?)
rs-ubuntu-24.04-arm-ak-pam 0.00% <ø> (?)
rs-ubuntu-24.04-arm-ak-platform 0.32% <0.00%> (?)
rs-ubuntu-24.04-arm-ak-platform-facts 83.14% <86.11%> (?)
rs-ubuntu-24.04-arm-ak-sysd 24.08% <24.08%> (?)
rs-windows-2025-ak-agent 4.55% <0.00%> (?)
rs-windows-2025-ak-agent-desktop 0.00% <0.00%> (?)
rs-windows-2025-ak-api-cli-gen 66.71% <ø> (?)
rs-windows-2025-ak-browser-support 23.80% <0.00%> (?)
rs-windows-2025-ak-cli 12.10% <0.00%> (?)
rs-windows-2025-ak-platform 0.33% <0.00%> (?)
rs-windows-2025-ak-platform-facts 79.37% <90.62%> (?)
rs-windows-2025-ak-sysd 22.73% <22.73%> (?)
swift 3.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 27, 2026 19:15 Inactive
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 27, 2026 20:16 Inactive
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 27, 2026 20:45 Inactive
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 27, 2026 21:27 Inactive
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 28, 2026 11:15 Inactive
pamtester only surfaces a generic "Authentication failure" — ak-sysd
logs to the systemd journal, not the container's stdout, so the real
server-side error has been invisible in every CI failure so far.
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 28, 2026 12:06 Inactive
@BeryJu
BeryJu marked this pull request as ready for review July 28, 2026 13:11
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 28, 2026 13:32 Inactive
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 28, 2026 16:20 Inactive
The domain_enroll readiness fix didn't resolve the intermittent
test_local_login_success failure, so the real root cause is still
unknown. pamtester only surfaces a generic "Authentication failure";
ak-sysd logs to the systemd journal, not the container's stdout, so
dump it on failure to actually see the server-side error next time.
@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 28, 2026 16:58 Inactive
ak-pam logs via syslog under its own identifier (libpam-authentik),
not the ak-sysd systemd unit, so a client-side failure after a
successful server-side auth (e.g. session-file writing) was invisible
to the existing diagnostic. Dump both on failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant