Skip to content

bounds check source index before indexing sources in source maps#501

Open
fr-manvi wants to merge 1 commit into
google:mainfrom
fr-manvi:sourcemap-source-index-bounds
Open

bounds check source index before indexing sources in source maps#501
fr-manvi wants to merge 1 commit into
google:mainfrom
fr-manvi:sourcemap-source-index-bounds

Conversation

@fr-manvi

Copy link
Copy Markdown

Bloaty reads source maps supplied with --source-map, and those are untrusted input just like the object files. In ForEachVLQSegment the source index starts as the second value of the first VLQ segment and is then accumulated from the deltas of every later segment, all of which come straight out of the mappings string, so it can be moved to any int32 value including negative ones. Nothing compares it against sources.size() before sources[source_file] runs, and since that is std::vector::operator[] the read simply goes wherever the index points, after which VlqSegment copies the resulting string_view into a std::string and follows a pointer that was never part of the vector. I hit it while feeding mutated maps at the wasm sourcemap tests: with sources holding a single entry, mappings of "AAAA,AgqjGAA,AAAA" moves the index to 100000 and bloaty dies on a bad address inside ForEachVLQSegment, while a smaller delta quietly prints a garbage file name instead. Checking the index against the vector at the point of use closes both, and throwing there keeps it consistent with how the rest of the parsers report malformed input. Test added alongside the existing wasm source map tests; it fails before the change and passes after, and the rest of the suite is unaffected.

A source map whose VLQ mappings move the source index outside the sources array made ForEachVLQSegment read a string_view from past the end of the vector and construct a std::string from the resulting wild pointer.
@google-cla

google-cla Bot commented Jul 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant