bounds check source index before indexing sources in source maps#501
Open
fr-manvi wants to merge 1 commit into
Open
bounds check source index before indexing sources in source maps#501fr-manvi wants to merge 1 commit into
fr-manvi wants to merge 1 commit into
Conversation
A source map whose VLQ mappings move the source index outside the sources array made ForEachVLQSegment read a string_view from past the end of the vector and construct a std::string from the resulting wild pointer.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloaty reads source maps supplied with --source-map, and those are untrusted input just like the object files. In ForEachVLQSegment the source index starts as the second value of the first VLQ segment and is then accumulated from the deltas of every later segment, all of which come straight out of the mappings string, so it can be moved to any int32 value including negative ones. Nothing compares it against sources.size() before sources[source_file] runs, and since that is std::vector::operator[] the read simply goes wherever the index points, after which VlqSegment copies the resulting string_view into a std::string and follows a pointer that was never part of the vector. I hit it while feeding mutated maps at the wasm sourcemap tests: with sources holding a single entry, mappings of "AAAA,AgqjGAA,AAAA" moves the index to 100000 and bloaty dies on a bad address inside ForEachVLQSegment, while a smaller delta quietly prints a garbage file name instead. Checking the index against the vector at the point of use closes both, and throwing there keeps it consistent with how the rest of the parsers report malformed input. Test added alongside the existing wasm source map tests; it fails before the change and passes after, and the rest of the suite is unaffected.