Skip to content

Allow implementations of server services to free message payloads on successful processing #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 16, 2026
Merged

Allow implementations of server services to free message payloads on successful processing #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fleetspeak/src/server/service/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ type Service interface {
// net.Error which reports as a timeout or temporary error, the message will
// be retried according the ServerRetryPolicy. Otherwise the error will be
// assumed to be permanent.
ProcessMessage(context.Context, *fspb.Message) error
// The implementation is allowed to set `m.Data = nil` to optimize memory
// usage if the operation is successful. On failure, it must make sure that
// `m.Data` is still intact when returning.
ProcessMessage(ctx context.Context, m *fspb.Message) error

// Stop initiates and waits for an orderly shut down. It will only be
// called when there are no more active calls to ProcessMessage and
Expand Down
Loading