Fix race condition and test flakiness in polling communicator Flush and Reset.#630
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix race condition and test flakiness in polling communicator Flush and Reset.#630copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…nd Reset.
In polling communicator, Reset forcefully canceled the context of active poll HTTP requests. The canceled poll deferred writing errors to pollComplete, which raced with Reset's non-blocking channel drain. Subsequent Flush calls received the canceled poll's error ("unable to contact any server").
Refactored polling communicator to use a clean broadcast channel pattern (pollDone) for Flush unblocking without forcibly canceling in-flight HTTP requests during Reset.
PiperOrigin-RevId: 948936881
copybara-service
Bot
force-pushed
the
cl/948936881
branch
from
July 16, 2026 16:18
169468c to
9e14214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition and test flakiness in polling communicator Flush and Reset.
In polling communicator, Reset forcefully canceled the context of active poll HTTP requests. The canceled poll deferred writing errors to pollComplete, which raced with Reset's non-blocking channel drain. Subsequent Flush calls received the canceled poll's error ("unable to contact any server").
Refactored polling communicator to use a clean broadcast channel pattern (pollDone) for Flush unblocking without forcibly canceling in-flight HTTP requests during Reset.