Report timeouts in execute_signed_command#222
Merged
panhania merged 1 commit intoJun 26, 2026
Conversation
panhania
reviewed
Jun 26, 2026
CRefice
force-pushed
the
crefice/execute_signed_command_timeout
branch
from
June 26, 2026 10:46
966b52e to
f4a6127
Compare
CRefice
force-pushed
the
crefice/execute_signed_command_timeout
branch
from
June 26, 2026 11:24
f4a6127 to
bdf6ca2
Compare
panhania
approved these changes
Jun 26, 2026
panhania
changed the title
execute_signed_command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
timed_outfield toResultfor theexecute_signed_commandaction, set to true if the subcommand exceeded the specified timeout. This is particularly useful on Windows where we didn't report any information on how the process exited (like we do with signals on Unix), so a timeout would just result in an exit code of 1 and an empty stdout/stderr.