test: run the logging-bunyan system tests in google cloud build#8705
test: run the logging-bunyan system tests in google cloud build#8705danieljbruce wants to merge 8 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Cloud Build configuration (cloudbuild.yaml) for the handwritten/logging-bunyan package to automate dependency installation, system testing, and optional code coverage reporting. The reviewer's feedback focuses on cleaning up the configuration file by removing commented-out boilerplate code, Secret Manager placeholders, and placeholder comments regarding Codecov integration to improve maintainability.
| # If you need specific credentials from Secret Manager, uncomment these: | ||
| # - 'GOOGLE_APPLICATION_CREDENTIALS=/secrets/sa-key.json' | ||
| id: 'run-system-tests' | ||
| waitFor: ['install-dependencies'] | ||
| # For Secret Manager, uncomment these (adjust secret name and volume path as needed): | ||
| # secretEnv: ['SA_KEY'] | ||
| # volumes: | ||
| # - name: 'sa-keys' | ||
| # path: '/secrets' |
There was a problem hiding this comment.
Remove the commented-out boilerplate code and Secret Manager placeholders to keep the configuration clean and maintainable.
id: 'run-system-tests'
waitFor: ['install-dependencies']| # The original codecov.sh script from Kokoro needs to be made available to GCB. | ||
| # Options: | ||
| # a) Commit codecov.sh into your repo (e.g., .kokoro/codecov.sh) and call it: | ||
| # if [ -f .kokoro/codecov.sh ]; then . ./.kokoro/codecov.sh; fi | ||
| # b) Replicate its functionality directly in this step. | ||
| # c) Store it in a GCS bucket and fetch it. | ||
| echo "Codecov reporting (if desired) would be integrated here." |
There was a problem hiding this comment.
Remove the placeholder comments and echo statement regarding Codecov integration options to keep the build configuration clean.
| # If you use Secret Manager for credentials, uncomment and configure: | ||
| # availableSecrets: | ||
| # secretManager: | ||
| # - versionName: projects/${PROJECT_ID}/secrets/YOUR_SERVICE_ACCOUNT_KEY_SECRET_NAME/versions/latest | ||
| # env: 'SA_KEY' # This env var will hold the secret value. Use it as GOOGLE_APPLICATION_CREDENTIALS in step 3 if needed. |
There was a problem hiding this comment.
Remove the commented-out Secret Manager configuration template block to keep the configuration file clean and maintainable.
danieljbruce
changed the title
1 participant
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕