Fix: Add missing namespace prefix to middleware naming#124
Draft
kkhristenko51 wants to merge 16 commits into
Draft
Fix: Add missing namespace prefix to middleware naming#124kkhristenko51 wants to merge 16 commits into
kkhristenko51 wants to merge 16 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart’s Traefik Ingress middleware annotation to include the release namespace prefix (matching Traefik’s cross-namespace middleware reference format), and adjusts Helm unit tests + chart version accordingly.
Changes:
- Prefix the generated rate-limit middleware reference with
.Release.Namespacein the Ingress annotation. - Update ingress Helm unit tests to assert namespace-prefixed middleware references.
- Bump chart version from
0.4.0to0.4.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/helm-charts/rosetta-mcp-server/templates/ingress.yaml |
Adds namespace prefix to the rate-limit middleware reference; modifies annotation rendering (currently introduces a rendering/duplication bug). |
src/helm-charts/rosetta-mcp-server/tests/ingress_test.yaml |
Updates unit tests to validate namespace-prefixed middleware references. |
src/helm-charts/rosetta-mcp-server/Chart.yaml |
Increments chart version to reflect the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
27
to
+31
| {{- if or $traefikMw $userAnnotations }} | ||
| annotations: | ||
| {{- if $traefikMw }} | ||
| traefik.ingress.kubernetes.io/router.middlewares: {{ $traefikMw }} | ||
| {{- end }} |
isolomatov-gd
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.