Fixed aggregation issue in grouping#187
Open
mwael-labs wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Step 4 solution in the Pandas exercises 03_Grouping -> Regiment.
The original code worked in older Pandas versions (pre 1.0) but now raises a
TypeErrorin modern Pandas (>= 1.5, 2.0+) because of stricter handling of non‑numeric columns during aggregation.Problem
regiment[regiment['regiment'] == 'Nighthawks'].groupby('regiment').mean()Old behaviour ignored non-numeric columns.
New behaviour attempts to aggregate all columns including non-numeric ones, which caused
TypeError: agg function failed [how->mean,dtype->object]Fix
the correct code should explicitly select
preTestScorecolumn.regiment[regiment['regiment'] == 'Nighthawks'] .groupby('regiment')['preTestScore'] .mean()Output
regiment Nighthawks 15.25 Name: preTestScore, dtype: float64Compatibility Note
This fix reflects changes introduced in Pandas after 2020:
Older notebooks may still run without error on legacy Pandas.
Modern environments require explicit column selection or
numeric_only=True