Improve lake gwt#562
Open
rubencalje wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends lake_from_gdf to better support the MF6 Lake Transport (LKT/GWT) workflow by allowing users to provide concentration inputs for lake-related fluxes (analogous to how fluxes are provided for the LAK/GWF model).
Changes:
- Adds support for GWT-specific lake setting columns (e.g.,
GWT_CONCENTRATION,GWT_RUNOFF,GWT_EXT-INFLOW) and writes them intolakeperioddata. - Improves outlet handling by recognizing
lakeout = "-1"(string) as a sentinel meaning “remove from model”. - Generalizes stress-period value resolution so settings can be taken from the dataset (when present) or treated as literal values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
224
to
231
| lakeout = _get_and_check_single_value(lake_gdf, "lakeout") | ||
| if isinstance(lakeout, str): | ||
| if isinstance(lakeout, str) and lakeout == "-1": | ||
| # an integer -1 could have been converted to a string after saving gdf to disk | ||
| lakeout = int(lakeout) | ||
| elif isinstance(lakeout, str): | ||
| # when lakeout is a string, it represents the boundname | ||
| # we need to find the lakeno that belongs to this boundname | ||
| boundnameout = lakeout |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the support for a GroundWater Transport (GWT) model in the Lake (LAK) package. The user can now supply the concentration of the fluxes in and out of the lake, in the same way he can supply the fluxes for the GroundWater Flow (GWF) model.