Skip to content

docs(restapi): fix Reversal response docs and add ViscusReversalResponse object#194

Open
ecunado wants to merge 2 commits into
devfrom
docs/fix-reversal-response-object
Open

docs(restapi): fix Reversal response docs and add ViscusReversalResponse object#194
ecunado wants to merge 2 commits into
devfrom
docs/fix-reversal-response-object

Conversation

@ecunado

@ecunado ecunado commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The Reversal endpoint docs (restendpoints.md#reversal) had a copy-paste mistake from the Deferred Tokenization section (introduced alongside cloudapi#432): the Returns table linked to DeferredTokenizationResponse, and there was no ViscusReversalResponse object to link to instead.

  • Added ViscusReversalResponse to restobjects.md, documenting the real gateway field set (httpStatus, acquirerTid, agreementNumber, amount, approvalCode, batchNumber, cardTypeName, currency, customFields, expiryDateMMYY, f25, issuerResponseCode, issuerResponseText, maskedCardNumber, serverDateTime, terminalDateTime, transactionReference, authorizationGuid, originalGuid, reversalGuid) — matching the 200 response example already present in restendpoints.md and the real Viscus reversal XML payload.
  • Fixed the Reversal endpoint's Returns table in restendpoints.md to link to the new object and to accurately describe the 200/400/403/422 outcomes (previously described a 400 "not eligible for deferred tokenization" error, which does not apply to reversal).
  • Added the missing timestamp optional parameter to the Reversal endpoint's Parameters table.
  • Fixed the ViscusReversalRequest link in restobjects.md that pointed to the non-existent restendpoints#reversal-operations anchor — now points to restendpoints#reversal, matching the actual heading.

Test plan

  • yarn build succeeds with no new broken links introduced (verified the only remaining #reversal-operations broken-anchor reports are in frozen historical version snapshots that predate this change).
  • Manually cross-checked the new ViscusReversalResponse fields against viscus.service.ts's reversal() method and the real Viscus reversal XML fixture in cloudapi (fixtures/transaction-status-with-nonce/transaction-result/txn-sale-reversal.xml).

ecunado added 2 commits July 9, 2026 13:50
…nse object

The Reversal endpoint's Returns table linked to DeferredTokenizationResponse
(copy-paste from the Deferred Tokenization section, added by cloudapi PR #432).
No ViscusReversalResponse object existed to link to, so it is now documented
with the real gateway field set. Also fixes the restobjects.md link that
pointed to the non-existent restendpoints#reversal-operations anchor, and adds
the missing timestamp parameter to the endpoint's Parameters table.
Sibling objects (BatchCloseRequest, MotoReversalRequest, etc.) don't carry
implementation-detail prefixes; ViscusReversalRequest/ViscusReversalResponse
leaked the internal cloudapi model class name into public docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant