Skip to content

feat(studio): flat inspector — Media group#2123

Open
vanceingalls wants to merge 7 commits into
studio-flat-03-layout-motionfrom
studio-flat-04-media
Open

feat(studio): flat inspector — Media group#2123
vanceingalls wants to merge 7 commits into
studio-flat-03-layout-motionfrom
studio-flat-04-media

Conversation

@vanceingalls

@vanceingalls vanceingalls commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Fourth PR in a 6-PR stack for the flat inspector redesign (see #2120 for the foundation and full stack list). Adds the FlatToggle primitive and the flat Media group (source/copy row, cutout sub-block, volume/rate/media-start sliders, loop/muted/has-audio-track toggles, fit/position rows), wired into the accordion.

Stack: #2120 (Foundation+Text) → #2121 (Style) → #2122 (Layout+Motion) → #2123 (this) → #2124 (Grade) → #2125 (Pinning + multi-field Text).

Why

Media covers every video/audio/image-specific control (playback, cutout, fit) that doesn't belong in the more general Style/Layout groups.

How

  • FlatToggle is a new shared primitive (used here for loop/muted/has-audio-track, and reused by the Grade group in the next PR).
  • FlatMediaSection composes six rows/sub-blocks across playback and framing controls.
  • Still behind STUDIO_FLAT_INSPECTOR_ENABLED (default off).

Test plan

  • Every row has a real DOM-event test with exact assertions — including branching toggle logic (e.g. muted vs. has-audio-track's two-sided onSetHtmlAttribute calls), which required an explicit fix-round during task review to reach full coverage.
  • Full monorepo suite green; oxlint/oxfmt/fallow clean.
  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (not applicable — internal Studio UI behind an off-by-default flag)

vanceingalls commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

@miga-heygen miga-heygen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as part of the 15-PR edit-panel redesign stack. Full stack review posted on #2120. No blockers on this PR. — Miga

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final current-head pass: 4b9c3cf. Reviewed the stack boundaries and current diff against the flat-inspector contracts; required checks have no failures/pending checks and no unresolved review threads remain. No new drift found; residual notes are non-blocking.

@vanceingalls vanceingalls force-pushed the studio-flat-03-layout-motion branch from bb1be1f to 906d740 Compare July 11, 2026 01:34
@vanceingalls vanceingalls force-pushed the studio-flat-04-media branch from 4b9c3cf to 523c461 Compare July 11, 2026 01:34

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseding earlier approval: the latest max-review pass found confirmed correctness issues in this flat-inspector stack (identity/selector-index state, hide-all write races, timing inference, slider pointer/keyboard/reset semantics, and duplicate React keys). Hold merge and require fixes plus re-review on the current stack head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants