feat(studio): flat inspector — Media group#2123
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
miga-heygen
left a comment
There was a problem hiding this comment.
Reviewed as part of the 15-PR edit-panel redesign stack. Full stack review posted on #2120. No blockers on this PR. — Miga
miguel-heygen
left a comment
There was a problem hiding this comment.
Final current-head pass: 4b9c3cf. Reviewed the stack boundaries and current diff against the flat-inspector contracts; required checks have no failures/pending checks and no unresolved review threads remain. No new drift found; residual notes are non-blocking.
bb1be1f to
906d740
Compare
4b9c3cf to
523c461
Compare
miguel-heygen
left a comment
There was a problem hiding this comment.
Superseding earlier approval: the latest max-review pass found confirmed correctness issues in this flat-inspector stack (identity/selector-index state, hide-all write races, timing inference, slider pointer/keyboard/reset semantics, and duplicate React keys). Hold merge and require fixes plus re-review on the current stack head.

What
Fourth PR in a 6-PR stack for the flat inspector redesign (see #2120 for the foundation and full stack list). Adds the
FlatToggleprimitive and the flat Media group (source/copy row, cutout sub-block, volume/rate/media-start sliders, loop/muted/has-audio-track toggles, fit/position rows), wired into the accordion.Stack: #2120 (Foundation+Text) → #2121 (Style) → #2122 (Layout+Motion) → #2123 (this) → #2124 (Grade) → #2125 (Pinning + multi-field Text).
Why
Media covers every video/audio/image-specific control (playback, cutout, fit) that doesn't belong in the more general Style/Layout groups.
How
FlatToggleis a new shared primitive (used here for loop/muted/has-audio-track, and reused by the Grade group in the next PR).FlatMediaSectioncomposes six rows/sub-blocks across playback and framing controls.STUDIO_FLAT_INSPECTOR_ENABLED(default off).Test plan
onSetHtmlAttributecalls), which required an explicit fix-round during task review to reach full coverage.oxlint/oxfmt/fallowclean.