fix(lint): detect over-constrained clip positioning#2219
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
Fallow audit reportFound 3 findings. Details
Generated by fallow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom-positioned
.clipelements now receive a lint warning before inheritedinset: 0silently stretches them into giant shapes. The rule identifies auto-sized clips that retain both horizontal or vertical edges, and points authors to the exactautoresets or explicit dimensions needed. Full-canvas clips and custom clips with the documented resets or dimensions remain clean.Test plan
bun test packages/lint/src— 354 passedbun run --filter @hyperframes/lint typecheckbunx oxfmt --check packages/lint/src/rules/core.ts packages/lint/src/rules/core.test.tsbunx oxlint packages/lint/src/rules/core.ts packages/lint/src/rules/core.test.tsbun run buildclip_inset_overconstrained