fix(audits): avoid nested effect false positives#2227
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Final review at current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix two audit false positives reported by a cursor-driven UI composition:
gsap_fullscreen_overlay_starts_visibleno longer treats an absolutely positionedinset: 0child inside an explicitly sized parent as a canvas-covering overlay.text_box_overflownow measures a control's direct text nodes without including transformed decorative descendants such as ripple or glow effects.Why
The static GSAP rule inferred canvas coverage from an element's own CSS without considering its constrained ancestor. The runtime layout audit selected an entire control's contents, allowing a scaled decorative child to inflate the text range and misattribute intentional effect overflow to the control label.
How
Test plan
Validation performed:
bun run --filter @hyperframes/lint test(359 passed)bun run --filter @hyperframes/cli test -- src/commands/layout-audit.browser.test.ts(31 passed)bun run --filter @hyperframes/lint typecheckbun run --filter @hyperframes/cli typecheckbunx oxfmt --checkon changed filesbunx oxlinton changed files