fix(product-launch): preserve brand font and accent roles#2231
Open
miguel-heygen wants to merge 1 commit into
Open
fix(product-launch): preserve brand font and accent roles#2231miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep product-launch brand remixing from selecting custom icon fonts as display/body typography and from collapsing a legitimate two-accent palette into one hue.
Why
Two independent product-launch runs required manual
frame.mdrepairs: custom glyph fonts such asvidaXLfontreplaced text fonts, while a secondary brand accent used in text/icons was discarded because it had nointeractiveBgcount.How
*fontglyph families.Test plan
node --test skills/product-launch-video/scripts/lib/tokens.test.mjsbun run test:skills(216 passed)bunx oxfmt --check skills/product-launch-video/scripts/build-frame.mjs skills/product-launch-video/scripts/lib/tokens.mjs skills/product-launch-video/scripts/lib/tokens.test.mjsbunx oxlint skills/product-launch-video/scripts/build-frame.mjs skills/product-launch-video/scripts/lib/tokens.mjs skills/product-launch-video/scripts/lib/tokens.test.mjsbun run lint:skills