Skip to content

fix(render): check disk space on write volumes#2232

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/render-disk-preflight-paths
Open

fix(render): check disk space on write volumes#2232
miguel-heygen wants to merge 1 commit into
mainfrom
fix/render-disk-preflight-paths

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Make local render disk preflight validate the temp/intermediate volume and final output volume instead of the project source volume.

Why

A render with TMPDIR and --output on a roomy external drive was blocked because preflight only measured the low-space project volume, even though that volume was not receiving the large render artifacts.

How

  • Add explicit disk paths to environment-check options.
  • Check both os.tmpdir() and dirname(outputPath) for local renders.
  • Include the checked path in low-space diagnostics.
  • Add a regression test proving the requested render volume is measured.

Test plan

  • bunx vitest run packages/cli/src/browser/preflight.test.ts (11 passed)
  • bun run --filter @hyperframes/cli typecheck
  • bunx oxfmt --check packages/cli/src/browser/preflight.ts packages/cli/src/browser/preflight.test.ts packages/cli/src/commands/render.ts
  • bunx oxlint packages/cli/src/browser/preflight.ts packages/cli/src/browser/preflight.test.ts packages/cli/src/commands/render.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant