fix(captions): avoid GSAP SRI mismatch in previews#2233
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent embedded-caption previews from silently rejecting the locally intercepted GSAP bundle when the composition pins a different CDN version with SRI.
Why
preview-frames.cjsserves local GSAP bytes for CDN script requests, but the originalintegrityhash remained on the script tag. If the local package version differed, Chrome rejected the response and the timeline never registered.How
integrity/crossoriginonly from GSAP script tags.Test plan
node --test skills/embedded-captions/scripts/preview-frames.test.cjsbunx oxfmt --check skills/embedded-captions/scripts/preview-frames.cjs skills/embedded-captions/scripts/preview-frames.test.cjsbunx oxlint skills/embedded-captions/scripts/preview-frames.cjs skills/embedded-captions/scripts/preview-frames.test.cjsbun run lint:skills