fix(cli): preserve snapshot alpha and create shot dirs#2238
Open
miguel-heygen wants to merge 1 commit into
Open
fix(cli): preserve snapshot alpha and create shot dirs#2238miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
keyframes --shotoutput pathsWhy
Transparent standalone overlays rendered correctly to VP9 alpha, but their snapshot review PNGs were forced to opaque RGB. The same workflow also failed with ENOENT when
--shottargeted a file inside a directory that did not already exist. Both behaviors reproduce on CLI 0.7.52.How
omitBackground: truefor snapshot screenshots and cropped snapshot capturesTest plan
bun run --filter @hyperframes/cli test -- --run src/commands/snapshot.test.ts src/commands/keyframes.test.ts src/capture/captureCompositionFrame.test.tsbun run --filter @hyperframes/cli typecheckbunx oxlinton the six changed files--shotpath without pre-creating the directory