fix(producer): tolerate rounded frame-boundary durations#2239
Open
miguel-heygen wants to merge 1 commit into
Open
fix(producer): tolerate rounded frame-boundary durations#2239miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
At 30fps, a static duration of
32.866667represents 986 frames after six-decimal serialization. Multiplication yields986.00001, so the producer probe stage's rawMath.ceilscheduled 987 frames and required a post-render one-frame trim.How
Convert duration to frame count by snapping values within 0.001 frame of an integer boundary, otherwise ceiling as before. This tolerance is wider than six-decimal metadata error even at high frame rates, while remaining far below a visible frame interval.
Test plan
32.866667at 30fps32.867still ceilings to 987bun test packages/producer/src/services/render/stages/probeStage.test.tsbun run --filter @hyperframes/producer typecheckbunx oxlint packages/producer/src/services/render/stages/probeStage.ts packages/producer/src/services/render/stages/probeStage.test.ts