fix(registry): remove invalid editorial video placeholder#2241
Open
miguel-heygen wants to merge 1 commit into
Open
fix(registry): remove invalid editorial video placeholder#2241miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
caption-editorial-emphasisWhy
hyperframes add caption-editorial-emphasisinstalled a component containing a timed<video>with nosrc. CLI 0.7.52 correctly raisedmedia_missing_src, so the component could not be reused directly and had to be removed from the final composition.How
The placeholder had no source and no runtime references, so the component now remains a transparent, host-agnostic caption overlay. The test reads the real registry artifact and asserts it has no
media_missing_srcfinding.Test plan
hyperframes add caption-editorial-emphasisfollowed by lint of the installed artifactmedia_missing_srcbefore the changebun run --filter @hyperframes/lint test -- --run src/rules/media.test.ts(22 passed)bunx oxlint packages/lint/src/rules/media.test.tsbun run --filter @hyperframes/lint typecheck