fix(lint): detect timelines in local external scripts#2242
Open
miguel-heygen wants to merge 1 commit into
Open
fix(lint): detect timelines in local external scripts#2242miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
<script src>files into the lint context.Why
Valid compositions that register
window.__timelinesin a local JavaScript file were incorrectly reported asmissing_timeline_registry, forcing authors to duplicate the registration inline.How
Project lint now resolves local script paths with the same project-root safety checks used for linked assets, ignores remote/data/blob scripts, and supplies the loaded source to timeline rules.
Test plan
bun run --filter @hyperframes/cli test -- --run src/utils/lintProject.test.tsbun run --filter @hyperframes/lint testbun run --filter @hyperframes/lint typecheckbun run --filter @hyperframes/cli typecheckbunx oxlint packages/lint/src/types.ts packages/lint/src/context.ts packages/lint/src/project.ts packages/lint/src/rules/core.ts packages/cli/src/utils/lintProject.test.ts