fix(cli): honor navigation timeout in diagnostics#2246
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make snapshot, check/inspect layout audits, and motion-shot browser navigation honor
PRODUCER_PAGE_NAVIGATION_TIMEOUT_MS.Why
These diagnostic paths hardcoded Puppeteer
page.gototo 10 seconds. On slow Windows Chrome launches, validate and render could be configured successfully while snapshot/check/inspect remained unusable.How
Add one shared diagnostic navigation-timeout resolver with the existing render environment contract and replace the hardcoded navigation budgets across composition capture, layout audit, and motion-shot capture. Invalid or missing values preserve the 10-second default.
Test plan
bunx vitest run packages/cli/src/utils/renderArgs.test.ts -t resolveDiagnosticNavigationTimeoutMsbun run --filter @hyperframes/cli typecheck