fix(media-use): fall back to bundled SFX#2257
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
media-use resolve --type sfxfall back to the shipped SFX library when the HeyGen CLI/catalog is unavailable. The remote catalog remains the first choice.Why
CLI 0.7.53 documents a bundled 19-file SFX fallback, but the resolver registry exposed only
heygen.audio.sounds. On a machine without the HeyGen CLI, even--intent whooshfailed withno provider could resolvealthoughwhoosh.mp3was installed with the skill.How
audio/assets/sfx/manifest.json.Test plan
bun run test:skills(219 passed)node --test skills/media-use/scripts/lib/registry.test.mjs skills/media-use/scripts/resolve.test.mjsnpx oxfmt --check skills/media-use/scripts/lib/bundled-sfx-provider.mjs skills/media-use/scripts/lib/registry.mjs skills/media-use/scripts/lib/registry.test.mjs skills/media-use/scripts/resolve.test.mjsnpx oxlint skills/media-use/scripts/lib/bundled-sfx-provider.mjs skills/media-use/scripts/lib/registry.mjs skills/media-use/scripts/lib/registry.test.mjs skills/media-use/scripts/resolve.test.mjsbun packages/cli/scripts/gen-skills-manifest.ts --check