fix(example): make warm-grain pass checks#2258
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make a freshly scaffolded
warm-grainexample pass the defaulthyperframes checkgate, including the no-video init path.Why
On CLI 0.7.53,
hyperframes init --example warm-grainrendered successfully but failed its own check with title/subtitle overlap errors, four contrast findings, and repeatedGSAP target #a-roll not foundwarnings after init removed the optional video element.How
Test plan
ok: true; runtime 0 errors/0 warnings; layout 0 findings; contrast 0 findingsbunx vitest run packages/cli/src/commands/init.test.ts(21 passed)npx oxfmt --check packages/cli/src/commands/init.test.ts registry/examples/warm-grain/index.html registry/examples/warm-grain/compositions/intro.html registry/examples/warm-grain/compositions/graphics.html registry/examples/warm-grain/compositions/captions.html