fix(render): scope strict lint to composition#2261
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scope pre-render lint to the file selected by
render --composition.Why
On CLI 0.7.53,
render --composition standalone.html --strictstill linted sibling root HTML files, emittedmultiple_root_compositions, and aborted. Users had to copy the same entry and assets into an isolated temporary project even though the command explicitly selected one composition.How
lintProjectto accept an explicit entry file.compositions/discovery and the project-wide multiple-root rule only for explicit-entry lint.--compositionis set.index.html.Test plan
bunx vitest run packages/cli/src/utils/lintProject.test.ts packages/cli/src/commands/render.test.ts(125 passed)bun run --filter @hyperframes/cli typechecknpx oxfmt --check packages/lint/src/project.ts packages/cli/src/commands/render.ts packages/cli/src/utils/lintProject.test.tsnpx oxlint packages/lint/src/project.ts packages/cli/src/commands/render.ts packages/cli/src/utils/lintProject.test.ts