Skip to content

fix(check): allow missing caption overrides#2263

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/optional-caption-overrides-check
Open

fix(check): allow missing caption overrides#2263
miguel-heygen wants to merge 1 commit into
mainfrom
fix/optional-caption-overrides-check

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Treat a missing root caption-overrides.json as an optional runtime resource in both check and validate.

Why

The caption runtime intentionally fetches overrides only when caption groups exist and safely handles a missing file, but browser diagnostics converted the expected 404/aborted request into http_error and request_failed. Users had to create an empty JSON shim before checks could pass.

How

  • ignore only the exact root /caption-overrides.json request when it is absent
  • keep other JSON failures and non-404 caption override responses reportable
  • share the same predicates across check and validate

Test plan

  • vitest run src/commands/validate.test.ts src/utils/checkBrowser.test.ts (27 passed)
  • tsc --noEmit
  • patched CLI against minimal caption composition with no override file: ok:true, zero runtime findings
  • repository pre-commit lint, format, fallow, tracked-artifact, and typecheck hooks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant