fix(check): allow missing caption overrides#2263
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat a missing root
caption-overrides.jsonas an optional runtime resource in bothcheckandvalidate.Why
The caption runtime intentionally fetches overrides only when caption groups exist and safely handles a missing file, but browser diagnostics converted the expected 404/aborted request into
http_errorandrequest_failed. Users had to create an empty JSON shim before checks could pass.How
/caption-overrides.jsonrequest when it is absentTest plan
vitest run src/commands/validate.test.ts src/utils/checkBrowser.test.ts(27 passed)tsc --noEmitok:true, zero runtime findings