Rename courtRoomId to roomId in change-court-room-for-multiday-hearing command#34
Merged
ozturkmenb merged 2 commits intoJul 10, 2026
Merged
Conversation
…g command Renames the nonDefaultDays[].courtRoomId field to roomId in the input command schema listing.command.change-court-room-for-multiday-hearing (stays a uuid), aligning it with the roomId naming used by other listing commands' nonDefaultDays. Updates the example, the single input read in ListingCommandApi (new ROOM_ID constant), and the command-api unit test and integration test payloads. The enriched command (changedDays[].courtRoomId) is left unchanged as an internal contract; courtscheduler is unaffected as its request is keyed on courtScheduleId.
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames
courtRoomId→roomIdin the input command schemahttp://justice.gov.uk/listing/courts/listing.command.change-court-room-for-multiday-hearing.json(the
nonDefaultDays[]items). The field remains auuid.Why
Aligns the
change-court-room-for-multiday-hearingcommand'snonDefaultDaysfield namewith the
roomIdconvention already used by other listing commands'nonDefaultDays(e.g.
update-hearing-for-listing).Files changed (input contract only)
listing.command.change-court-room-for-multiday-hearing.jsonschema — field +requiredlistlisting.command.change-court-room-for-multiday-hearing.jsonexampleListingCommandApi— newROOM_IDconstant; the single input-fallback read now readsroomId(the enriched write of
courtRoomIdis preserved)ListingCommandApiTest+ChangeCourtRoomForMultidayHearingIT— input payloadsDeliberately NOT changed
changedDays[].courtRoomId— internal downstream contract, not caller-facingcpp-context-listing-courtscheduler— its request carries onlycourtScheduleId(no room field),so the rename does not cross the context boundary
Verification
mvn clean install— BUILD SUCCESS./runIntegrationTests.sh— GREEN. Failsafe suite 256/0/0 (3 skipped);ChangeCourtRoomForMultidayHearingIT8/8 passed. Deployed-schema validation confirmedroomIdis accepted/required end-to-end (server.log shows only the intended negative-test violations, none on the field name).Follow-ups (separate repos, out of scope here)
This is a breaking change to the public command contract. Any caller that sends
courtRoomIdfor this command must switch toroomId:cpp-apitestspayload builders (change-court-room-for-multiday area)cpp-ui-listingif it posts this command