CIMD-3915: set verdict in dismiss decision#122
Merged
Conversation
erolkurelihmcts
requested review from
Somanagouda2,
jwiddowson,
narayansingh and
psrvarma
and removed request for
a team,
Somanagouda2,
jwiddowson and
narayansingh
|
|
|
|
psrvarma
previously requested changes
Jul 15, 2026
| // conviction date or convicting court | ||
| decisionAggregate.putConvictionInfo(offenceId, | ||
| new ConvictionInfo(offenceId, | ||
| dismissOffenceDecision.getOffenceDecisionInformation().getVerdict(), |
Contributor
There was a problem hiding this comment.
does the event have the verdict information?
Contributor
There was a problem hiding this comment.
can you please check the schema end to end of these 2 fields are mandatory anywhere ?
psrvarma
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See CIMD-3915
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist