Support h2 upgrade#985
Open
cwe-dixa wants to merge 9 commits into
Open
Conversation
Contributor
Author
|
Tests are failing with mima (missing class) because I deleted the now unused prior knowledge handler. Should I bring it back? |
Collaborator
|
yes, bring it back. it can just be a stub that throws execptions everywhere. |
Contributor
Author
Brought it back. Had to add some nowarns, since it now throws exceptions instead. |
hamnis
reviewed
Jul 17, 2026
| serverResource(routes).use { server => | ||
| val addr = server.address | ||
| Resource | ||
| .make(IO.blocking(new Socket(addr.getHostName, addr.getPort)))(s => |
Collaborator
There was a problem hiding this comment.
this could be Resource.fromAutocloseable ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clients (like the jdk HttpClient) expects to be able to upgrade an h1 connection to h2 by sending an
Upgradeheader.Previously, the library only supported prior-knowledge h2, but this pr adds support for h1 -> h2 upgrades.
Added a couple of tests to verify and all existing tests pass as well.