Add optional ETRecord generation/saving for the xnnpack recipe#239
Open
sachinhambar wants to merge 1 commit into
Open
Add optional ETRecord generation/saving for the xnnpack recipe#239sachinhambar wants to merge 1 commit into
sachinhambar wants to merge 1 commit into
Conversation
Exposes a generate_etrecord kwarg on export_to_executorch that, when set, saves an ETRecord alongside the .pte file for use with the ExecuTorch Inspector. Currently only the xnnpack recipe forwards the flag through to to_edge_transform_and_lower; other recipes log a warning instead of silently no-oping. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional ETRecord generation support during ExecuTorch export, enabling easier debugging and analysis with the ExecuTorch Inspector.
Changes
generate_etrecordargument toexport_to_executorch.{name}_etrecord.bin) is generated alongside the exported.pteartifact.to_edge_transform_and_lower(...)call, allowing ETRecord generation during lowering.generate_etrecord=Trueis requested with unsupported recipes (portable,coreml,cuda,cuda-windows,metal) to avoid silent failures.Behavior
xnnpackportablecoremlcudacuda-windowsmetalImpact
generate_etrecord=Trueis explicitly specified.