[test do not merge] snapshot golden tests#1446
Draft
ludfjig wants to merge 7 commits into
Draft
Conversation
ludfjig
added
regen-goldens
ludfjig
force-pushed
the
snapshot-golden-tests
branch
2 times, most recently
from
db6f7fb to
b5a0b52
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
A guest exception handler runs on the IST1 exception stack. When such a handler writes a copy-on-write page (present and read-only after a snapshot), the first write raises a page fault. Routing that page fault through the same IST1 stack makes the CPU reset RSP to the top of IST1 and push the fault frame over the live handler frame, clobbering it. The handler then returns to a garbage RIP and the guest aborts. Deliver page faults on their own IST2 stack so a nested fault leaves the outer handler frame intact. The page-fault stack occupies the second of the two scratch pages reserved at the top of the region, so snapshot sizes and golden hashes are undisturbed. Add a deterministic regression test that installs a handler which writes a never-touched copy-on-write page, forcing a nested fault on every run. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
snapshot-golden-tests
branch
from
b5a0b52 to
cc3e7f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.