Fix just-clippyw recipe#1561
Merged
Merged
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the surrogate build script to emit appropriate linker arguments for both MSVC and GNU (mingw) Windows toolchains, enabling just clippyw cross-checks from non-Windows hosts (Fixes #1559).
Changes:
- Detects the target toolchain via
CARGO_CFG_TARGET_ENVand branches forgnuvs MSVC. - Adds mingw-specific linker args (
-nostartfiles,-Wl,-e,..., subsystem) while keeping existing MSVC flags.
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
jsturtevant
approved these changes
Jun 18, 2026
jsturtevant
left a comment
jsturtevant
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me
andreiltd
approved these changes
Jun 19, 2026
jprendes
reviewed
Jun 19, 2026
jprendes
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1559
I use this all the time on linux machine to verify
just clippywould pass on windows target