Control sorting through props for iTwin and iModel tables#223
Open
arome wants to merge 4 commits into
Open
Conversation
arome
requested review from
alexdunae,
aruniverse,
ben-polinsky,
kckst8 and
toddsouthenbentley
as code owners
arome
changed the title
alexdunae
reviewed
Jul 10, 2026
| DataGrid, | ||
| GRID_DEFAULT_LOCALE_TEXT, | ||
| GridColDef, | ||
| GridSortModel, |
Contributor
There was a problem hiding this comment.
Given that we have such specific sort capabilities, do you think it would be better to define our own "sort model" data type, limited to our actual field names?
| * Controlled sort model. When provided, the table's sort state is fully | ||
| * controlled by the parent and must be kept in sync via `onSortModelChange`. | ||
| */ | ||
| sortModel?: GridSortModel; |
Contributor
There was a problem hiding this comment.
It looks like this just effects the table view, not the tile/card view. My initial thought is that would be good to keep sorting unified between both views. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to control the sorting of the tables through props.
